Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace() #2209

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Add trace() #2209

merged 2 commits into from
Sep 17, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Sep 10, 2019

Description
We advertise trace() in the User Guide as a debug tool wrapping Kint::trace() but it isn't actually there. This PR adds it to Common.php.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

Userguide actually shows, Kint::trace(); as how to use it, but I'm fine adding this feature in. Just need to update the docs.

@MGatner
Copy link
Member Author

MGatner commented Sep 11, 2019

Ah I see - the subheaders misled me since the other two are global functions. Well it’s fine either way but if this seems good I’ll update that doc.

@lonnieezell
Copy link
Member

yeah, I think it's worth doing.

@MGatner
Copy link
Member Author

MGatner commented Sep 11, 2019

@lonnieezell All set!

@MGatner MGatner requested a review from lonnieezell September 14, 2019 18:26
@lonnieezell lonnieezell merged commit f2bf43b into codeigniter4:develop Sep 17, 2019
@MGatner MGatner deleted the kint-trace branch September 17, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants