Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign key columns #2201

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Sep 9, 2019

Description
Currently getForeignKeys() only returns information on the related tables. While helpful, this doesn't allow any interactions based on those keys as it lacks the column name. This PR adds the locals and foreign column names to the returned object.

Note that SQLite3 does not have this information available, but does have an additional field sequence (also added) which is handy for composite keys. The updated User Guide makes this clear.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

nice one. thanks.

@lonnieezell lonnieezell merged commit afc7f1a into codeigniter4:develop Sep 9, 2019
@MGatner MGatner deleted the foreign-key-columns branch September 9, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants