WIP Use site_url for route-based RedirectResponse #2196
Conversation
base_url does not actually add the base path if the given URL is absolute (i.e., starts with a slash) and does not add the indexPage. Both is necessary for the redirect response to work correctly in case of routes. site_url handles this correctly. Fixes codeigniter4#2119
| $this->config->baseURL = 'http://example.com'; | ||
| $this->config = new App(); | ||
| $this->config->baseURL = 'http://example.com'; | ||
| $this->config->indexPage = ''; |
There was a problem hiding this comment.
Setting indexPage to empty breaks the form & HTML helper tests big-time!
There was a problem hiding this comment.
Why does changing the local App instance here influence other tests?
There was a problem hiding this comment.
And how to resolve this? I need a different indexPage for the test
There was a problem hiding this comment.
Don't change it in setUp(), set the specific values you need only on the test where they differ.
There was a problem hiding this comment.
Ohhh I get it now, you were trying to "undo" the injection of your test. Let me think of another way to approach this...
jim-parry
changed the title
|
@lonnieezell I believe this was addressed by your URL function rework. Can you confirm? |
|
@MGatner This was not fixed and i think the change makes sense here, as |
|
Great. I think this is good then but it breaks the default redirect response test because by default the index page is included (which is not reflected in the assertion). Easy fix if @yol is around. |
|
Hey, sorry I kind of lost track. So the PR is still good? But the "default" redirect response is broken? Can you clarify what you mean by default? |
|
Basically, in tests/system/HTTP/RedirectResponseTest.php around line 61, you should change the expected response from "http://example.com/exampleRoute" to "http://example.com/index.php/exampleRoute" Ref. https://travis-ci.org/codeigniter4/CodeIgniter4/jobs/623289981#L586 |
|
Fixed in #2496 |
Description
base_url does not actually add the base path if the given URL is absolute (i.e., starts with a slash) and does not add the indexPage. Both is necessary for the redirect response to work correctly in case of routes. site_url handles this correctly.
Fixes #2119
Checklist: