Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Fix name of ForeignKeyChecks #2190

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Sep 5, 2019

Description
Docs have the wrong names for foreign key methods.
I think I was supposed to use [ci skip] on the commit but trying it here anyways...

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@jim-parry
Copy link
Contributor

i see that travis-ci is hard at work, so am guessing that [ci skip] in the PR title doesn't help :(
Live & learn (me too)

@MGatner
Copy link
Member Author

MGatner commented Sep 5, 2019

Whoops, yeah I remembered too late. Dance for me Travis!

@lonnieezell
Copy link
Member

[ci skip] used to work well. Had kind of forgotten about it until recently. However - as of January 6th there was a very strange bug. Not sure if it ever got resolved or if that's what is happening here...

@MGatner
Copy link
Member Author

MGatner commented Sep 5, 2019

That thread references [ci skip], [ci-skip], and [skip ci] 😮

@lonnieezell lonnieezell merged commit fc8d447 into codeigniter4:develop Sep 5, 2019
@MGatner MGatner deleted the foreign-key-methods branch September 5, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants