Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check defined for constants #2183

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Check defined for constants #2183

merged 1 commit into from
Sep 4, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Sep 3, 2019 •
edited
Loading

Description
Currently the APP_NAMESPACE and COMPOSER_PATH define right out, without checking for defined(). This prevents using an alternative bootstrap to load from different locations, e.g. a modular test bootstrapper.

This PR adds checks for existing constants before defining them.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 8da88e0 into codeigniter4:develop Sep 4, 2019
@MGatner MGatner deleted the composer-path branch September 4, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @lonnieezell