-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include .gitignore in starters #2155
Conversation
Good idea. One teeny change requested :) |
I have merged this, but I don't think that the gitignore in the framework release prep will make any difference. It will end up in vendor/codeigniter4/framework, which will have no effect on a developer's project. |
How does https://github.com/codeigniter4/devstarter get seeded? That's what really needs the updated files. EDIT: And appstarter of course. |
It doesn't ... any updates are done manually when there are app changes in a release. |
Ah thanks for clarifying. I misunderstood that deployment script - sorry for the trouble! |
The appstarter and framework repos are updated as a "normal" part of a release, |
See admin/README.md and admin/workflow.md |
Description
devstarter and appstarter both have very old versions of .gitignore - it isn't getting updated when new deployments are made. This PR adds .gitignore to the list of files copied out during a release.
Checklist: