Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include .gitignore in starters #2155

Merged
merged 3 commits into from
Aug 22, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Aug 20, 2019

Description
devstarter and appstarter both have very old versions of .gitignore - it isn't getting updated when new deployments are made. This PR adds .gitignore to the list of files copied out during a release.

Checklist:

  • Securely signed commits

admin/release-appstarter Outdated Show resolved Hide resolved
@jim-parry
Copy link
Contributor

Good idea. One teeny change requested :)

@jim-parry jim-parry merged commit 95effac into codeigniter4:develop Aug 22, 2019
@jim-parry
Copy link
Contributor

I have merged this, but I don't think that the gitignore in the framework release prep will make any difference. It will end up in vendor/codeigniter4/framework, which will have no effect on a developer's project.

@MGatner
Copy link
Member Author

MGatner commented Aug 22, 2019

How does https://github.com/codeigniter4/devstarter get seeded? That's what really needs the updated files. EDIT: And appstarter of course.

@MGatner MGatner deleted the gitignore-deploy branch August 22, 2019 17:35
@jim-parry
Copy link
Contributor

It doesn't ... any updates are done manually when there are app changes in a release.

@MGatner
Copy link
Member Author

MGatner commented Aug 22, 2019

Ah thanks for clarifying. I misunderstood that deployment script - sorry for the trouble!

@jim-parry
Copy link
Contributor

The appstarter and framework repos are updated as a "normal" part of a release,
That's where the admin/release-appstarter and release-framework scripts are invoked.
This is all done on my system, and then the releases are manually tagged on github.
Not all can be automated, but as much as possible has been :)

@jim-parry
Copy link
Contributor

See admin/README.md and admin/workflow.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants