Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current
fit()
isn't working as expected - it does the correct crop location and resize but it is taking a much smaller-than-necessary crop from large images. This iteration starts with the premise that the crop should be the entire width or height of the image, calculates the other axis based on the desired aspect, takes the much larger crop then resizes to the desired output.Tests are hard for image handlers but I have run this through a handful of scenarios.
Checklist: