Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Toolbar on downloads #2118

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Aug 1, 2019

Description
Fix for #2117. This change injects $response from the filter to the toolbar and checks for a DownloadResponse. If found, the toolbar quits.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 1ed8d36 into codeigniter4:develop Aug 2, 2019
@MGatner MGatner deleted the toolbar-downloads branch August 2, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants