Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original email port #2092

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Original email port #2092

merged 2 commits into from
Aug 20, 2019

Conversation

jim-parry
Copy link
Contributor

This is the original Email port from CodeIgniter 3.
It is inelegant and tested by assumption only (it worked it CI3, right?).

It is, however, available "now", as a "better-than-nothing" provision for CodeIgniter 4's initial release.

I will continue to work on a more elegant and tested Email package, targeting 4.1.

@jim-parry jim-parry requested a review from lonnieezell July 11, 2019 06:49
@jim-parry
Copy link
Contributor Author

Bit of a hit on code coverage :(

@jim-parry jim-parry closed this Aug 16, 2019
@jim-parry jim-parry deleted the ported-email branch August 16, 2019 07:57
@MGatner
Copy link
Member

MGatner commented Aug 16, 2019

Closed? Could this mean... Email 4.0?

@lonnieezell
Copy link
Member

I'm cool with this if it was closed by mistake. Feel free to merge if that's the case.

@jim-parry jim-parry restored the ported-email branch August 20, 2019 04:34
@jim-parry jim-parry reopened this Aug 20, 2019
@jim-parry jim-parry merged commit 868e0d0 into codeigniter4:develop Aug 20, 2019
@jim-parry
Copy link
Contributor Author

Dropped by mistake, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants