getExtension() should return string #2068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in other case this cause i.e. exception during validation if file is not provided ``` 'is_image[upload_' . $i . ']|max_size[upload_' . $i . ',6144]' ``` I thought to declare this method as `public function getExtension(): ?string` but this will be worse option.
|
This is resolved in a slightly different manner by #2128 |
|
#2128 already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in other case this cause i.e. exception during validation if file is not provided
I thought to declare this method as
public function getExtension(): ?stringbut this will be worse option.