Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict filter matching of uris so they require an exact match. Fixes #2038 #2039

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Restrict filter matching of uris so they require an exact match. Fixes #2038 #2039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/Filters/Filters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ private function pathApplies(string $uri, $paths)
// need to make pseudo wildcard real
$path = strtolower(str_replace('*', '.*', $path));
// Does this rule apply here?
if (preg_match('#' . $path . '#', $uri, $match) === 1)
if (preg_match('#^' . $path . '$#', $uri, $match) === 1)
{
return true;
}
Expand Down