Add CLI check to RouteCollection

[MGatner]

Description
CodeIgniter.php sets the request method on request or clirequest service, so RouteCollection needs to check the proper service to get the correct HTTPVerb to account for CLI, spoofing, and standard scenarios.
See #2021

FWIW I believe the reason this wasn't caught is that all the request & routing clauses in CodeIgniter.php have conditional ! (ENVIRONMENT === 'testing') to be able to simulate non-CLI requests from CLI. There should probably be a test that spoofs its own environment (if possible) just to check for spark integrity.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

I think a slightly better fix here is to either pass in the request instance either through the constructor or through a setter method. That removes the dependency creation back to CodeIgniter.php, where it already knows which type of request it is.

[MGatner]

That's a good idea! I'm out for a few days but I'll take a look when I get a chance. Glad for anyone else to hop in before then.

[MGatner]

Looking at this, get/set HTTPVerb and the $HTTPVerb property only appear to be used internally to RouteCollection and really just for getRoutes(). It is also always just a duplicate of $_SERVER['REQUEST_METHOD'] (old version) or $request->getMethod() (current revision).

Do we get rid of HTTPVerb altogether, overload the constructor to __construct(FileLocator $locator, $moduleConfig, $request = null) and then just use $request->getMethod() for getRoutes() when $verb isn't supplied explicitly?

[MGatner]

One more place for HTTPVerb, called from Router but extraneous as it is simply injecting what is loaded by default:

./Router/Router.php:390: $routes = $this->collection->getRoutes($this->collection->getHTTPVerb());

[lonnieezell]

@MGatner I've got this about wrapped up, actually. Just have one more test I have to fix up. It was a bigger change than expected. Due to the way routeCollection is used I didn't want to force a new call within route files to that, so I added it as a dependency to the Router class, which then sets the HTTPVerb on the RouteCollection itself.

[MGatner]

Oh great! Thanks for addressing it - I look forward to seeing your solution. Any thoughts on testing (re: my original comment "FWIW...")?