Toolbar fix for custom collectors #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that's fine for now, but does warrant a deeper look into the disconnect between user guide and functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Custom collectors fail because toolbar.tpl.php tries to parse their view file from
SYSTEMPATH . 'Debug/Toolbar/Views/'. See #1971 for complete description of the issue.This change allows
Collector->display()to return a string (as stated in the User Guide) and then, when detected in the view template, displays it directly instead of looking for a separate template to parse.There's probably a better way to handle this by checking for a namespaced view template for the collector.
Checklist: