Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

having (Is NULL deletion) #1933

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Conversation

nowackipawel
Copy link
Contributor

Is it breaks anything or will repair having('MAX(sth)', null, false)
before:

SELECT `aht_cur_id_2` `cur_id_2`, `aht_cur_id_1` `cur_id_1`, `aht_rate` `rate`
FROM `t_api_trading_trades`
GROUP BY `aht_cur_id_2`, `aht_cur_id_1`
HAVING MAX(aht_api_trade_id) IS NULL

now:

SELECT `aht_cur_id_2` `cur_id_2`, `aht_cur_id_1` `cur_id_1`, `aht_rate` `rate`
FROM `t_api_trading_trades`
GROUP BY `aht_cur_id_2`, `aht_cur_id_1`
HAVING MAX(aht_api_trade_id)

Is it breaks anything or will repair having('MAX(sth)', null, false)
before:
```
SELECT `aht_cur_id_2` `cur_id_2`, `aht_cur_id_1` `cur_id_1`, `aht_rate` `rate`
FROM `t_api_trading_trades`
GROUP BY `aht_cur_id_2`, `aht_cur_id_1`
HAVING MAX(aht_api_trade_id) = NULL
```
now:
```
SELECT `aht_cur_id_2` `cur_id_2`, `aht_cur_id_1` `cur_id_1`, `aht_rate` `rate`
FROM `t_api_trading_trades`
GROUP BY `aht_cur_id_2`, `aht_cur_id_1`
HAVING MAX(aht_api_trade_id)
```
@lonnieezell
Copy link
Member

I have no idea if it will break something, since I'm sure it was there for a reason, but a comparison to the CI3 codebase and it looks like it was removed from there at some point since we forked that code.

Will merge.

@lonnieezell lonnieezell merged commit d2f8c42 into codeigniter4:develop Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants