Entity exception for non existed props.

[nowackipawel]

As for now if code calls non existed property of entity causing ErrorException with no info at all.
This PR is changing ErrorException to EntityException with translated information like this:
"Trying to access non existent property fle_amount_fromss of App\Entities\Fee\FeeLevel"

[lonnieezell]

Honestly, I'm tempted to return null in these occasions. Because it is possible to set values that are not defined properties I kind of think that you should just be able to check for null instead of wrapping something in a try/catch block every time.

I know at least one of the other major frameworks handles it this way.

@jim-parry What are your thoughts?

[nowackipawel]

As for now I believe PRed behaviour is better than actual :)

[lonnieezell]

You're right it's better than current, but that doesn't mean it's the right long-term solution. :)

Still waiting to hear @jim-parry thoughts.

[jim-parry]

I favor the idea of declaring entity properties explicitly, and thus support this PR.

[lonnieezell]

The part I'm concerned about is when you have a join, and select some fields from the other table. That property was not explicitly set on the object, but was implicitly defined through the query result, though I suppose it would still pass muster as existing at the time someone tried to get a property? It's late and I'm not honestly sure of that answer. Will have to investigate later.

[jim-parry]

Hmmm. If you are planning that an entity be the result of a join, would you not then be able to "predict" that it should have a specific property? I haven't used the Entity class, and don't have a good feel for what would work best :-/

[nowackipawel]

If entity is a result of joint it will contain all the own properties + new ones from join. Properties from join are public and should not produce that exception.

…

On Thu, Apr 11, 2019, 12:04 Instructor, BCIT ***@***.***> wrote: Hmmm. If you are planning that an entity be the result of a join, would you not then be able to "predict" that it should have a specific property? I haven't used the Entity class, and don't have a good feel for what would work best :-/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1927 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIBmUrGeoA1UD8NmmgGuXVoivUaAVXROks5vfsJigaJpZM4ckfTh> .

[lonnieezell]

@nowackipawel Now that my brain is a little clearer and less tired - you're right. I'm good with this then.

If you are planning that an entity be the result of a join, would you not then be able to "predict" that it should have a specific property?

sometimes, but not always since the entity will be used in different situations that might require different sets of data joined in, sometimes only for a single call.