Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History::SetFiles check #1778 #1869

Merged
merged 1 commit into from
Mar 26, 2019
Merged

History::SetFiles check #1778 #1869

merged 1 commit into from
Mar 26, 2019

Conversation

atishhamte
Copy link
Contributor

@atishhamte atishhamte commented Mar 25, 2019

History::SetFiles check #1778

As per the issue raised, In case one of the files in WRITEPATH.'debugger/debugbar_*.json is empty the method setFiles will crash. The reason for the crash is that History::setFiles does not check if the local variable $contents contain an object before using it in the assignment.

I have added a check whether the JSON is valid or not. If not then it will skip the iteration else proceed with it.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@atishhamte
Copy link
Contributor Author

Travis ci failed only in PHP 7.2, MySQL but passed in all other scenario.
@lonnieezell @jim-parry could you please check as I have changed nothing related to redis

@lonnieezell lonnieezell merged commit f577d49 into codeigniter4:develop Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants