Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MigrationRunner issue with definition resolved #1865

Merged
merged 7 commits into from
Mar 26, 2019
Merged

MigrationRunner issue with definition resolved #1865

merged 7 commits into from
Mar 26, 2019

Conversation

atishhamte
Copy link
Contributor

@atishhamte atishhamte commented Mar 24, 2019

MigrationRunner issue with definition resolved #1766

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

What problem is this solving? Was there a bug? Please provide better descriptions about what and, more importantly, why the PR is needed.

Additionally - there are some failing tests.

@atishhamte
Copy link
Contributor Author

Was trying to resolve the Migration Runner issue. Will reference and close this today

@atishhamte atishhamte changed the title Migration check MigrationRunner issue with definition resolved Mar 25, 2019
@lonnieezell lonnieezell merged commit e73d3c3 into codeigniter4:develop Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MigrationRunner::version should return "current version string on success"
2 participants