Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore callbacks in routes list #1859

Merged
merged 1 commit into from
Mar 23, 2019
Merged

Ignore callbacks in routes list #1859

merged 1 commit into from
Mar 23, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Mar 22, 2019

Description
The CLI command Routes iterates routes from system & app to display them as a table, but ends up trying to display callbacks. This change ignores any $to destinations that aren't strings.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Ignore callbacks in routes list
d324bc0 
The CLI command Routes iterates routes from system & app to display them as a table, but ends up trying to display callbacks. This change ignores any `$to` destinations that aren't strings.
This was referenced Mar 22, 2019
Merged
Merged
@lonnieezell lonnieezell merged commit 7e1c666 into codeigniter4:develop Mar 23, 2019
@MGatner MGatner deleted the cli-routes-strings-filter branch March 23, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @lonnieezell