Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding environment to .env #1749

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Feb 20, 2019

Description
A QOL recommendation after working through the user guide and perusing forums for questions that arose. "Handling Multiple Environments" describes how to set the environment in .env but is very terse.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Seems like maybe an oversight that .env has no seed value for the environment? "Handling Multiple Environments" covers how to set this but is very terse. I propose adding a pre-commented version front-and-center
Ref: https://codeigniter4.github.io/userguide/general/environments.html
@lonnieezell lonnieezell merged commit 8b32c04 into codeigniter4:develop Feb 20, 2019
@MGatner MGatner deleted the feature/env-env branch February 20, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants