Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New View Layout functionality for simple template functionality. #1729

Merged
merged 1 commit into from
Feb 18, 2019
Merged

New View Layout functionality for simple template functionality. #1729

merged 1 commit into from
Feb 18, 2019

Conversation

lonnieezell
Copy link
Member

Provides the ability to use layout views that can then be extended by child views, with content sections.

jim-parry
jim-parry approved these changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@jim-parry jim-parry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)
Nothing jumps out as needing work, except perhaps the signing :-/
Ths will be a good feature for the framework.

@jim-parry
Copy link
Contributor

There are still time execution timing errors messing with travis-ci. I will fix the ones I can.

@lonnieezell lonnieezell merged commit 1aa3c31 into develop Feb 18, 2019
@lonnieezell lonnieezell deleted the layouts branch March 13, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-parry jim-parry jim-parry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonnieezell @jim-parry