Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form helper enctype unescaped #1714

Closed
wants to merge 3 commits into from

Conversation

nowackipawel
Copy link
Contributor

No description provided.

```enctype="multipart/form-data"``` looks ugly :)
@nowackipawel
Copy link
Contributor Author

enctype="multipart/form-data" looks ugly :)

@samsonasik
Copy link
Member

escaping html attributes is fine, see #345 and #351 that closed.

@nowackipawel
Copy link
Contributor Author

nowackipawel commented Feb 10, 2019

thx for pointing this out. it is just idea... to make html clearer .

btw/ not sure why travis is failing after [beae5b2] it looks like it wasn't see the changes.

@lonnieezell
Copy link
Member

If you click on the travis Details link you can see what the exact errors that are happening are.

However, we don't need to complicate the code with special case checks for the sake of making HTML look pretty. It's perfectly functional as is, and safe and accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants