Update PHP dependency to 7.2

.travis.yml

@@ -1,7 +1,6 @@
 language: php
 
 php:
-  - 7.1
   - 7.2
   - 7.3
   - nightly

README.md

@@ -72,7 +72,8 @@ Please read the [*Contributing to CodeIgniter*](https://github.com/codeigniter4/
 
 ## Server Requirements
 
-PHP version 7.1 or higher is required, with the following extensions installed: 
+PHP version 7.2 or higher is required, with the following extensions installed: 
+
 
 - [intl](http://php.net/manual/en/intl.requirements.php)
 - [libcurl](http://php.net/manual/en/curl.requirements.php) if you plan to use the HTTP\CURLRequest library

admin/framework/README.md

@@ -60,7 +60,7 @@ Please read the [*Contributing to CodeIgniter*](https://github.com/codeigniter4/
 
 ## Server Requirements
 
-PHP version 7.1 or higher is required, with the following extensions installed: 
+PHP version 7.2 or higher is required, with the following extensions installed: 
 
 - [intl](http://php.net/manual/en/intl.requirements.php)
 - [libcurl](http://php.net/manual/en/curl.requirements.php) if you plan to use the HTTP\CURLRequest library

admin/framework/composer.json

@@ -5,7 +5,7 @@
     "homepage": "https://codeigniter.com",
     "license": "MIT",
     "require": {
-        "php": ">=7.1",
+        "php": ">=7.2",
         "ext-curl": "*",
         "ext-intl": "*",
         "kint-php/kint": "^2.1",

admin/starter/README.md

@@ -47,7 +47,7 @@ The user guide updating and deployment is a bit awkward at the moment, but we ar
 
 ## Server Requirements
 
-PHP version 7.1 or higher is required, with the following extensions installed: 
+PHP version 7.2 or higher is required, with the following extensions installed: 
 
 - [intl](http://php.net/manual/en/intl.requirements.php)
 - [libcurl](http://php.net/manual/en/curl.requirements.php) if you plan to use the HTTP\CURLRequest library

admin/starter/composer.json

@@ -5,7 +5,7 @@
     "homepage": "https://codeigniter.com",
     "license": "MIT",
     "require": {
-        "php": ">=7.1",
+        "php": ">=7.2",
         "codeigniter4/framework": "^4@alpha"
     },
     "require-dev": {

admin/userguide/composer.json

@@ -5,7 +5,7 @@
     "homepage": "https://codeigniter.com",
     "license": "MIT",
     "require": {
-        "php": ">=7.1",
+        "php": ">=7.2",
         "codeigniter4/framework": "^4"
     },
     "support": {

composer.json

@@ -5,7 +5,7 @@
     "homepage": "https://codeigniter.com",
     "license": "MIT",
     "require": {
-        "php": ">=7.1",
+        "php": ">=7.2",
         "ext-curl": "*",
         "ext-intl": "*",
         "ext-json": "*",

contributing.md

@@ -35,7 +35,7 @@ If you change anything that requires a change to documentation then you will nee
 
 ### Compatibility
 
-CodeIgniter4 requires PHP 7.1.
+CodeIgniter4 requires PHP 7.2.
 
 ### Branching
 

contributing/guidelines.rst

@@ -74,7 +74,7 @@ be highlighted in the next release after it has been merged.
 PHP Compatibility
 =================
 
-CodeIgniter4 requires PHP 7.1.
+CodeIgniter4 requires PHP 7.2.
 
 Backwards Compatibility
 =======================

public/index.php

@@ -1,7 +1,7 @@
 <?php
 
 // Valid PHP Version?
-$minPHPVersion = '7.1';
+$minPHPVersion = '7.2';
 if (phpversion() < $minPHPVersion)
 {
 	die("Your PHP version must be {$minPHPVersion} or higher to run CodeIgniter. Current version: " . phpversion());

system/Autoloader/Autoloader.php

@@ -410,7 +410,7 @@ protected function discoverComposerNamespaces()
 		{
 			return false;
 		}
-		
+
 		$composer = include COMPOSER_PATH;
 
 		$paths = $composer->getPrefixesPsr4();

system/Commands/Server/Serve.php

@@ -48,7 +48,7 @@
  */
 class Serve extends BaseCommand
 {
-	protected $minPHPVersion = '7.1';
+	protected $minPHPVersion = '7.2';
 
 	protected $group       = 'CodeIgniter';
 	protected $name        = 'serve';

system/Entity.php

@@ -268,15 +268,15 @@ public function __set(string $key, $value = null)
 		}
 
 		$isNullable = false;
-		$castTo = false;
+		$castTo     = false;
 
-		if(array_key_exists($key, $this->_options['casts']))
+		if (array_key_exists($key, $this->_options['casts']))
 		{
-			$isNullable = substr($this->_options['casts'][$key],0,1) === '?';
-			$castTo = $isNullable ? substr($this->_options['casts'][$key], 1) : $this->_options['casts'][$key];
+			$isNullable = substr($this->_options['casts'][$key], 0, 1) === '?';
+			$castTo     = $isNullable ? substr($this->_options['casts'][$key], 1) : $this->_options['casts'][$key];
 		}
 
-		if(!$isNullable || !is_null($value))
+		if (! $isNullable || ! is_null($value))
 		{
 			// Array casting requires that we serialize the value
 			// when setting it so that it can easily be stored
@@ -293,7 +293,6 @@ public function __set(string $key, $value = null)
 			{
 				$value = json_encode($value);
 			}
-
 		}
 
 		// if a set* method exists for this key,
@@ -318,7 +317,6 @@ public function __set(string $key, $value = null)
 		return $this;
 	}
 
-
 	//--------------------------------------------------------------------
 
 	/**
@@ -443,13 +441,13 @@ protected function mutateDate($value)
 
 	protected function castAs($value, string $type)
 	{
-		if(substr($type,0,1) === '?')
+		if (substr($type, 0, 1) === '?')
 		{
-			if($value === null)
+			if ($value === null)
 			{
 				return null;
 			}
-			$type = substr($type,1);
+			$type = substr($type, 1);
 		}
 
 		switch($type)

system/Helpers/html_helper.php

@@ -161,7 +161,6 @@ function img($src = '', bool $indexPage = false, $attributes = ''): string
 			$src['alt'] = $attributes['alt'] ?? '';
 		}
 
-
 		$img = '<img';
 
 		foreach ($src as $k => $v)
@@ -185,7 +184,7 @@ function img($src = '', bool $indexPage = false, $attributes = ''): string
 		}
 
 		// prevent passing "alt" to stringify_attributes
-		if(is_array($attributes) && isset($attributes['alt']))
+		if (is_array($attributes) && isset($attributes['alt']))
 		{
 			unset($attributes['alt']);
 		}

user_guide_src/source/installation/upgrade_4xx.rst

@@ -30,7 +30,7 @@ subforum for an uptodate list!
 
 **Namespaces**
 
-- CI4 is built for PHP7.1+, and everything in the framework is namespaced, except for the helpers.
+- CI4 is built for PHP7.2+, and everything in the framework is namespaced, except for the helpers.
 
 **Application Structure**
 

user_guide_src/source/intro/requirements.rst

@@ -2,9 +2,9 @@
 Server Requirements
 ###################
 
-`PHP <http://php.net/>`_ version 7.1 or newer is required, with the 
+`PHP <http://php.net/>`_ version 7.2 or newer is required, with the 
 `*intl* extension <http://php.net/manual/en/intl.requirements.php>`_ 
-installed. `Why 7.1 <https://gophp71.org/>`_?
+installed. 
 
 The following PHP extensions should be enabled on your server:
 ``php-json``, ``php-mbstring``, ``php-mysqlnd``, `php-xml``
@@ -17,7 +17,7 @@ Currently supported databases are:
 
   - MySQL (5.1+) via the *MySQLi* driver
   - PostgreSQL via the *Postgre* driver
-  - SqLite3 via the *SQLite3* driver
+  - SQLite3 via the *SQLite3* driver
 
 Not all of the drivers have been converted/rewritten for CodeIgniter4.
 The list below shows the outstanding ones.

user_guide_src/source/testing/feature.rst

@@ -328,7 +328,7 @@ Asserts that $fragment is found within the JSON response. It does not need to ma
     // Is true
     $this->assertJSONFragment(['config' => ['key-a']);
 
-.. note:: This simply uses phpUnit's own `assertArraySubset() <https://phpunit.readthedocs.io/en/7.1/assertions.html#assertarraysubset>`_
+.. note:: This simply uses phpUnit's own `assertArraySubset() <https://phpunit.readthedocs.io/en/7.2/assertions.html#assertarraysubset>`_
     method to do the comparison.
 
 **assertJSONExact($test)**