New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Files module #1636

Merged

lonnieezell merged 1 commit into codeigniter4:develop from jim-parry:refactor/files

Dec 31, 2018

Contributor

jim-parry commented Dec 30, 2018

Refactor the Files module:

simplified File::getMimeType(), as fileinfo is built-in
removed two never used exceptions in Files\Exceptions\FileExceptions
removed the corresponding message lines in Language/en/Files
The exceptions are not thrown by any of our code, and there are equivalent exceptions for uploaded files in the HTTP module.


          Refactor Files module

878a054

Member

lonnieezell commented Dec 31, 2018

Had to go tracking through the code, but yes, looks good to me.

lonnieezell merged commit af33482 into codeigniter4:develop

jim-parry deleted the refactor/files branch

January 1, 2019 21:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet