-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release framework script clean up #1606
release framework script clean up #1606
Conversation
I applied exclude composer.json from |
Appreciate your effoirts to cleanup, but...
The extra semi-colon is a valid point, though not worthy of a PR on its own |
I reverted the files deletion. For |
.gitattributres should be neither here nor there. I took the approach of only copying in what should be part of the framework download, rather than copying most/all of it and then excluding with .gitattributes. trying to keep things simple. |
For example, I create project via composer create-project -sdev codeigniter4/appstarter The ├── LICENSE
├── README.md
├── application
├── composer.json
├── composer.lock
├── contributing.md
├── env
├── license.txt
├── public
├── spark
├── writable
└─- vendor/codeigniter4
├── framework
├── LICENSE
├── README.md
├── application
├── composer.json
├── contributing.md
├── env
├── license.txt
├── phpunit.xml.dist
├── public
├── spark
├── system
└── writable By use ├── LICENSE
├── README.md
├── application
├── composer.json
├── composer.lock
├── contributing.md
├── env
├── license.txt
├── public
├── spark
├── writable
└─- vendor/codeigniter4
├── framework
├── README.md
├── composer.json
├── contributing.md
├── license.txt
├── system so, no more |
Hmm - I thought I mentioned earlier that application & public, and the other files there, would be useful for comparison if the framework is updated for someone who already has the starter installed. What is needed perhaps is a difference report between the new release and the previous or locally installed one. This might be something to bring up on the forum - just what should or shouldn't be in each distribution. They are startig points, but probably not best addressed through a PR, or a number of PRs each addressing one aspect of the distros. |
I can get the ball rollig on a forum discussion, for community input on this, but not until next week or later. My time is tight right now, and alpha.4 should be out this weekend, with the folder renaming. |
Maybe we can split to difference. If a new project starts, of course nothing can be compared. Certainly different when we do an update. Only a few config files need to be compared. |
"split to difference"? I don't understand. |
I mean, like when we use rsync. For example we exclude config/database.php during an update |
@jim-parry I think the flow before distribute
framework
files as below:dist/framework/*
withrm -rf *
to ensure no unneeded old files not removed.composer.jsoncontributing.md license.txt )Checklist: