Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar updates #1571

Merged
merged 11 commits into from
Dec 3, 2018
Merged

Toolbar updates #1571

merged 11 commits into from
Dec 3, 2018

Conversation

natanfelles
Copy link
Contributor

Description

  1. Moved Toolbar configs to its own configuration file
  2. Added an History collector
  3. No more static methods. Toolbar works totally independent of the ToolbarFilter
  4. Allow user set custom toolbar views path, to use a custom design, etc
  5. Appended .json extension to toolbar history files

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit e326916 into codeigniter4:develop Dec 3, 2018
@jim-parry
Copy link
Contributor

No changes needed to the user guide?

@jim-parry
Copy link
Contributor

Unit tests for the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natanfelles @jim-parry @lonnieezell