Integrates Autoloader and FileLocator #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natanfelles
force-pushed
the
autoloader
branch
from
22cfa20 to
958ff8e
Compare
…der and not any other string part - checking the full filepath
natanfelles
changed the title
|
It looks like this PR got away on you a bit... it includes
Is this all part of autoload/filelocator enhancement? There's a lot more here than is mentioned in 1552! |
|
No. The Logger is not related. But PhpStorm highlighted the constructor type hint error when I was in the Services, then I did. |
|
This looks good to go. |
lonnieezell
approved these changes
Dec 7, 2018
natanfelles
commented
Dec 8, 2018
| } | ||
|
|
||
| return new \CodeIgniter\Autoloader\FileLocator(new \Config\Autoload()); |
There was a problem hiding this comment.
To solve issue 1552, it all started in this line. Using a new \Config\Autoload() it was not possible to dynamically use Autoloader namespaces.
|
@jim-parry Yes. I believe that is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1552
Checklist: