Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using protected intead of public modifier for setUp() function in tests #1556

Merged
merged 2 commits into from
Dec 3, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/Test/CIDatabaseTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public function loadDependencies()
*
* @throws ConfigException
*/
public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion system/Test/CIUnitTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class CIUnitTestCase extends TestCase
*/
protected $configPath = '../application/Config';

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/API/ResponseTraitTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class ResponseTraitTest extends \CIUnitTestCase
*/
protected $formatter;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Autoloader/AutoloaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class AutoloaderTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Autoloader/FileLocatorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class FileLocatorTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/CLI/CLITest.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class CLITest extends \CIUnitTestCase

private $stream_filter;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/CLI/CommandRunnerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class CommandRunnerTest extends \CIUnitTestCase
protected $logger;
protected $runner;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/CLI/ConsoleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class ConsoleTest extends \CIUnitTestCase

private $stream_filter;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Cache/CacheFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class CacheFactoryTest extends \CIUnitTestCase
private $cacheFactory;
private $config;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Cache/Handlers/DummyHandlerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class DummyHandlerTest extends \CIUnitTestCase
{
private $dummyHandler;

public function setUp()
protected function setUp()
{
$this->dummyHandler = new DummyHandler();
$this->dummyHandler->initialize();
Expand Down
2 changes: 1 addition & 1 deletion tests/system/Cache/Handlers/FileHandlerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ private static function getKeyArray()
private $fileHandler;
private $config;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Cache/Handlers/MemcachedHandlerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ private static function getKeyArray()
private static $dummy = 'dymmy';
private $config;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Cache/Handlers/RedisHandlerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ private static function getKeyArray()
private static $dummy = 'dymmy';
private $config;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/CodeIgniterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class CodeIgniterTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Commands/CommandsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class CommandsTest extends \CIUnitTestCase
protected $logger;
protected $runner;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Commands/SessionsCommandsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class SessionsCommandsTest extends \CIUnitTestCase
protected $runner;
private $result;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/CommonFunctionsSendTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
class CommonFunctionsSendTest extends \CIUnitTestCase
{

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/CommonFunctionsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class CommonFunctionsTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Config/BaseConfigTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class BaseConfigTest extends CIUnitTestCase

//--------------------------------------------------------------------

public function setup()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Config/DotEnvTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class DotEnvTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setup()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Config/ServicesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class ServicesTest extends \CIUnitTestCase
protected $config;
protected $original;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/ControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class ControllerTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/BaseQueryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class QueryTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/AliasTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class AliasTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/CountTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class CountTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/DeleteTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class DeleteTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/DistinctTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class DistinctTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/EmptyTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class EmptyTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/FromTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class FromTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/GroupTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class GroupTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/InsertTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class InsertTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/JoinTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class JoinTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/LikeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class LikeTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/LimitTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class LimitTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/OrderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class OrderTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/PrefixTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class PrefixTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/ReplaceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class ReplaceTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/SelectTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class SelectTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/TruncateTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class TruncateTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/UpdateTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class UpdateTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Builder/WhereTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class WhereTest extends \CIUnitTestCase

//--------------------------------------------------------------------

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Live/ConnectTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class ConnectTest extends CIDatabaseTestCase

protected $group2;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Live/ForgeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class ForgeTest extends CIDatabaseTestCase
*/
protected $forge;

public function setUp()
protected function setUp()
{
parent::setUp();
$this->forge = \Config\Database::forge($this->DBGroup);
Expand Down
2 changes: 1 addition & 1 deletion tests/system/Database/Live/ModelTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class ModelTest extends CIDatabaseTestCase

protected $seed = 'Tests\Support\Database\Seeds\CITestSeeder';

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down
Loading