Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin/scripts #1553

Merged
merged 12 commits into from
Nov 30, 2018
Merged

Admin/scripts #1553

merged 12 commits into from
Nov 30, 2018

Conversation

jim-parry
Copy link
Contributor

Version 2 of the release build scripts.
Tested locally, and all appears well (famous last words).
I won't merge & run this until you have a chance to comment on it.
First live run will be manual for "release-deploy" :-/
@lonnieezell @natanfelles What do you think?

@lonnieezell
Copy link
Member

My bash skills are rusty enough that I'm not 100% sure of the scripts you've written, but it all looks pretty thorough. I'm good with it. And excited to see how it all works out!

@jim-parry jim-parry added this to the 4.0.0 milestone Nov 29, 2018
@natanfelles
Copy link
Contributor

Seems pretty good. Please, merge it! :)

@jim-parry
Copy link
Contributor Author

@lonnieezell Should we continue to bundle the docs with the "framework" redistributable? They are available for separate download, which could be made composer-installable (it isn't at the moment). The released docs will also be available through github.io (and won't need hosting on our website).

Download sizes:

  • framework with docs - 3.2MB gz or 3,6MB zip
  • framework without docs - 455KB gz or 728KB zip
  • docs - 2.7MB gz or 2.9MB zip
  • appstarter - 44KB gz or 72KB zip

@lonnieezell
Copy link
Member

I would just include the framework personally.

@jim-parry
Copy link
Contributor Author

@lonnieezell It looks like travis-ci is not happy with your LiveConnectTest changes :(

  1. CodeIgniter\Database\Live\ConnectTest::testConnectWithMultipleCustomGroups
    ErrorException: Trying to get property of non-object
    /home/travis/build/codeigniter4/CodeIgniter4/tests/system/Database/Live/ConnectTest.php:20

@lonnieezell
Copy link
Member

That was corrected this morning, i believe. Re-run your tests at Travis for this and it should be good.

@jim-parry jim-parry changed the title WIP Admin/scripts Admin/scripts Nov 30, 2018
@jim-parry jim-parry merged commit 5f1e482 into codeigniter4:develop Nov 30, 2018
@jim-parry jim-parry deleted the admin/scripts branch January 1, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants