Access to model's last inserted ID #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to get insertID after insert($insert_data, false) which returns CodeIgniter\Database\*\Result object instead of insertID.
|
There is an insertID() provided in Database\BaseConnection. Can it be used instead of a new method, with a different accessor style (getInsertID vs insertID)? |
|
Ofc there is insertID() method in BaseConnection but BaseConnection is not accessible from outside of the model after insert is called with false as the 2nd parameter. |
|
Fair enough. It just struck me as odd, but makes sense now. |
atefBB
reviewed
Apr 6, 2020
| @@ -551,6 +570,8 @@ public static function classToArray($data, string $dateFormat = 'datetime'): arr | |||
| public function insert($data = null, bool $returnID = true) | |||
There was a problem hiding this comment.
I think this feature (returning inserted row ID with $returnID flag) isn't well documented! Need to be documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to get insertID after insert($insert_data, false) which returns CodeIgniter\Database*\Result object instead of insertID.