Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct class namespacing in the user guide #1402

Merged
merged 2 commits into from
Nov 3, 2018

Conversation

jim-parry
Copy link
Contributor

@jim-parry jim-parry commented Nov 1, 2018

A sweep through the user guide, to correct class namespacing declarations.
Fixes #1401

@jim-parry jim-parry added the documentation Pull requests for documentation only label Nov 1, 2018
@jim-parry jim-parry requested a review from lonnieezell November 1, 2018 23:59
user_guide_src/source/cli/cli.rst Outdated Show resolved Hide resolved
user_guide_src/source/extending/core_classes.rst Outdated Show resolved Hide resolved
user_guide_src/source/incoming/controllers.rst Outdated Show resolved Hide resolved
user_guide_src/source/incoming/controllers.rst Outdated Show resolved Hide resolved
user_guide_src/source/models/model.rst Outdated Show resolved Hide resolved
user_guide_src/source/models/model.rst Outdated Show resolved Hide resolved
user_guide_src/source/models/model.rst Outdated Show resolved Hide resolved
user_guide_src/source/models/model.rst Outdated Show resolved Hide resolved
user_guide_src/source/models/model.rst Outdated Show resolved Hide resolved
@jim-parry
Copy link
Contributor Author

@lonnieezell Thanks for checking. Sorry about the typos!
I think I am clearer on the namespacing now :-/

@hwiesmann
Copy link

Hi,

I think there is another one on CodeIgniter4/tutorial/static_pages.html. A backslash is missing before CodeIgniter:
<?php namespace App\Controllers; class Pages extends CodeIgniter\Controller {

@jim-parry
Copy link
Contributor Author

@hwiesmann I thought I got that.
The original "namespace App\Controllers; class Pages extends CodeIgniter\Controller {" should become "namespace App\Controllers; use CodeIgniter\Controller; class Pages extends Controller {" after all my changes.

@jim-parry jim-parry merged commit 90365de into codeigniter4:develop Nov 3, 2018
@jim-parry jim-parry deleted the docs/namespace branch November 3, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants