is_unique tried to connect to default database instead of defined in DBGroup. #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes codeigniter4#1326 - passing DBGroup do Validation.
Adding DBGroup to $data and passing it to processRules. codeigniter4#1326
Finally passing correct DBGroup to Database::connect; codeigniter4#1326
lonnieezell
reviewed
Oct 28, 2018
system/Validation/Validation.php
Outdated
| @@ -123,10 +123,13 @@ public function __construct($config, RendererInterface $view) | |||
| * | |||
| * @return bool | |||
| */ | |||
| public function run(array $data = null, string $group = null): bool | |||
| public function run(array $data = null, string $group = null, ?string $db_group = null): bool | |||
There was a problem hiding this comment.
no need for the optional signifier when using null. Prefer not to have those.
optional signifier has been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1326