Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies #1286

Merged
merged 4 commits into from
Oct 4, 2018
Merged

Cookies #1286

merged 4 commits into from
Oct 4, 2018

Conversation

lonnieezell
Copy link
Member

  • Cleaned up MockResponse for cookie handling.
  • Refactored delete_cookie helper to use a new deleteCookie method in Response.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

samsonasik
samsonasik reviewed Oct 3, 2018
View reviewed changes
system/HTTP/Response.php
if ($cookie['name'] == $name)
{
$cookie['value'] = '';
$cookie['expires'] = '';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break; should can be here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. thanks!

@lonnieezell lonnieezell merged commit 4d61afd into develop Oct 4, 2018
@lonnieezell lonnieezell deleted the cookies branch October 15, 2018 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonnieezell @samsonasik