Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep part 1 #1248

Merged
merged 4 commits into from
Sep 27, 2018
+116 −455
Merged

Release prep part 1 #1248

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1caf1cc
Release prep part 1
jim-parry Sep 27, 2018
3cb4e17
Improve the upgrading guide
jim-parry Sep 27, 2018
e64d3c2
Removed some todos
jim-parry Sep 27, 2018
cddddd9
Clean up the guide
jim-parry Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions system/View/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@
*
* ClassFormerlyKnownAsTemplateParser
*
* @todo Views\Parser_Test
* @todo Common::parse
* @todo user guide
* @todo options -> delimiters
*
* @package CodeIgniter\View
*/
class Parser extends View
Expand Down
11 changes: 5 additions & 6 deletions user_guide_src/source/installation/upgrade_4xx.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ interpretation as before
root for your app
- There is also a `writable` folder, to hold cache data, logs, and session data
- The `application` folder looks very similar to that for CI3, with some
name changes (eg Filters instead of hooks) and capitalization, and some subfolders
name changes, and some subfolders
moved to the `writable` folder
- There is no longer a nested `application/core` folder, as we have
a different mechanism for extending framework components (see below)
Expand All @@ -55,8 +55,8 @@ you are most comfortable with, including the "HMVC" style

**Controllers**
- Controllers extend \CodeIgniter\Controller instead of CI_Controller
- They don't use a constructor any more (to invoke CI "magic"); they
instead call `initController`
- They don't use a constructor any more (to invoke CI "magic") unless
that is part of a bvase controller you make
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this was supposed to be base not bvase :)

- CI provides `Request` and `Response` objects for you to work with -
more powerful than the CI3-way
- If you want a base controller (MY_Controller in CI3), make it
Expand All @@ -76,7 +76,7 @@ of your component

**Views**
- Your views look much like before, but they are invoked differently ...
instead of CI3's `$this->load->view(x);` you can use `view(x);`
instead of CI3's `$this->load->view(x);` you can use `echo view(x);`
- CI4 supports view "cells", to build your response in pieces
- The template parser is still there, but substantially
enhanced
Expand All @@ -89,8 +89,7 @@ don't have to
component

**Helpers**
- Helpers are pretty much the same as before, except that instead
of `$this->load->helper(x);` you would now use `helper(x);`
- Helpers are pretty much the same as before, though some have been simplified

**Extending the framework**
- You don't need a `core` folder to hold `MY_...` framework
Expand Down
2 changes: 0 additions & 2 deletions user_guide_src/source/libraries/validation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,6 @@ custom error messages, and retrieve one or more errors to display.
By default, error messages are derived from language strings in ``system/Language/en/Validation.php``, where
each rule has an entry.

@todo: Determine how to easily add custom rule messages.**

.. _validation-custom-errors:

Setting Custom Error Messages
Expand Down