Fix #1244 (form_hidden declaration) #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benoit VRIGNAUD <[email protected]>
|
Thanks for the PR! In the future we ask that contributions be GPG signed. Thanks. |
|
Just an FYI - I see that the timing test failed, and that the two times were out by 10 seconds. That doesn't sound right at all, and we may have to rethink how we are testing such times. It looks like the timer test is meant to ensure that the formats are the same, regardless of the formatter (Time vs IntlDateFormatter). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the form_hidden function declaration to fix bug #1244