Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for buffer problem #1242

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

puschie286
Copy link
Contributor

Simple fix for open buffers ( opend by tryToRouteIt )

Signed-off-by: Christoph Potas [email protected]

Signed-off-by: Christoph Potas <[email protected]>
@jim-parry
Copy link
Contributor

That fixes most of them 🗡️ Is something similar affecting CLI\ConsoleTest and FeatureTestCaseTest?

Good catch!

@puschie286
Copy link
Contributor Author

yes its the same for ConsoleTest & FeatureTestCaseTest.
commits are coming soon ;)

@jim-parry
Copy link
Contributor

Looks good, thanks!

@jim-parry jim-parry merged commit a3d85f0 into codeigniter4:develop Sep 25, 2018
@puschie286 puschie286 deleted the WorkaroundBufferProblem branch September 28, 2018 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants