Fix undefined function xml_convert at Database\BaseUtils #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this one was missed. Did you want to add the docs page for it, and add it to the helpers/index.rst in the user guide? |
samsonasik
force-pushed
the
xml-convert
branch
from
de37c2e to
58e40b5
Compare
|
@jim-parry I've added documentation for it, and add |
|
@jim-parry Thoughts on this one? |
|
I am fine with this. It originally arose because the xml_helper wasn't ported to CI4, and it looks like the also missing MySQLi/Utils has been addressed too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by add xml helper ported from CI3 source