Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds valid_json which is using json_last_error() === JSON_ERROR_NONE #1187

Merged
merged 3 commits into from
Sep 4, 2018
Merged

Adds valid_json which is using json_last_error() === JSON_ERROR_NONE #1187

merged 3 commits into from
Sep 4, 2018

Conversation

nowackipawel
Copy link
Contributor

it will return false if json is null, similar to existing funcs , i.e. valid_url

@nowackipawel
Adds valid_json which is using json_last_error() === JSON_ERROR_NONE
8041060 
it will return false if json is null, similar  to existing funcs , i.e. valid_url
lonnieezell
lonnieezell requested changes Aug 30, 2018
View reviewed changes
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs, and add a test.

@lonnieezell lonnieezell merged commit ded0479 into codeigniter4:develop Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowackipawel @lonnieezell