Small but useful. Entity class. #1176 #1186
Conversation
I've changed name which i proposed before (json-object -> json) cuz I use default parameter for json_decode($value, [$assoc = false]) in calling.
system/Entity.php
Outdated
| case 'json': | ||
| if (function_exists('json_decode') && is_string($value) && (strpos($value, '[') === 0 || strpos($value, '{') === 0)) | ||
| { | ||
| $value = json_decode($value, false); |
There was a problem hiding this comment.
You should check the json_error_code here, also, to ensure it's valid json, or throw an exception otherwise, so the developer knows what went wrong.
There was a problem hiding this comment.
Firstly I am not convinced about throwing exception when case 'array' won't throw anything when serialized array is formatted incorrectly.
Secondly if you think it is really required to throw exception with json (let me say more, I do not see any proper exception in CI that I could throw in this case; should I use "Config Exception" and a new Language/en/Entuty.php file dedicated to it?) then we have to clarify that
json_error_code() will return error if $value is null; what could be very likely case when data is retrieved from database. Do you reckon we should treat NULL value as exception or just ignore it? I bet: ignore it, as we do in the moment.
--
i will add docs and test in tmrw.
There was a problem hiding this comment.
That's a fair point about the array - except that PHP itself will throw exceptions if the serialization fails, while I'm pretty sure json_encode doesn't throw an exception, it just returns false, leaving it to us to throw that ourself.
Yes - I do agree that we ignore nulls like we currently do, because that's a possible valid response from a database query.
There was a problem hiding this comment.
exception + language (messages) files added and docs modified
initially used in system/Entity.php
tl;dr; small improvements according to experience with using json, json-array casting in implementation of my cms formatting extract code for JSON casting (which was almost identical for "json" and "json-array") to castAsJson support for "string" and numeric casting: 0x322, 0272, 0b1010101, 1234e0, removing force casting to object as "json" (what was too much according to actual manual)
|
@lonnieezell could you check if everything is ok? |
|
Merged in PR #1283 |
I've changed name which i proposed before (json-object -> json) cuz I use default parameter for json_decode($value, [$assoc = false]) in calling.