Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust log level to match RFC 5424 #1178

Merged
merged 3 commits into from
Sep 4, 2018

Conversation

sugenganthos
Copy link
Contributor

Log level threshold is adjusted to match RFC 5424.
Set threshold to 'debug' level practically show 'all' debug messages. This usually the developer wants on debugging sessions

Change log level number to match RFC 5424. Enabling threshold on 'debug' level is same as show all messages. This is what developer wants on debugging stage
@lonnieezell
Copy link
Member

This causes a test to fail. Please adjust the test so that it passes again.

@sugenganthos
Copy link
Contributor Author

I have update the Test. But maybe another test will fail. Sorry, I'm newbie in test unit. This CI4 framework has big test file. I still fail to configure in my local server. Don't know what to do. I have ask in forum but no one answer.

@lonnieezell
Copy link
Member

I believe the other tests that were failing for you were incorrect. We have a couple of tests that randomly fail due to timestamp issues that we haven't fixed quite yet. All tests are passing now. Thanks.

@lonnieezell lonnieezell merged commit 06a4980 into codeigniter4:develop Sep 4, 2018
@sugenganthos
Copy link
Contributor Author

The test on my local server is failed says 'class not found' or something. It is broken path. It resolved if I edit every file and put 'include' on absolute path
Note: I install PHPUnit myself, not using composer included with CI

@lonnieezell
Copy link
Member

Please ask on the forums for help getting PHPunit working for you. This is for tracking bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants