Update Response.php #1173
Merged
Update Response.php #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove {csp-style-nonce} from end page when CSP is not enabled. If page send to user contains {csp-style-nonce} or {csp-style-nonce} then it would not pass html check and says 'no value'.
Needs to check about performance because regex will runs to a whole views regardless of CSP setting.
|
I'm fine with this PR - but let's use str_replace - it's faster than preg_replace. |
|
Okay then, lets use str_replace instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove {csp-style-nonce} from end page when CSP is not enabled. If page send to user contains {csp-style-nonce} or {csp-style-nonce} then it would not pass html check and says 'no value'.
Needs to check about performance because regex will runs to a whole views regardless of CSP setting.