reduce str_replace in View/Parser::render() #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonnieezell
reviewed
Aug 13, 2018
system/View/Parser.php
Outdated
|
|
||
| // Was it cached? | ||
| if (isset($options['cache'])) | ||
| { | ||
| $cacheName = $options['cache_name'] ?: str_replace('.php', '', $view); | ||
| $cacheName = $options['cache_name'] ?: $template; |
There was a problem hiding this comment.
I believe this should be the $view variable, shouldn't it? Otherwise you're missing the .php extension. At which point, you could have left the previous couple of lines just like they were unless there's a specific use for template and view later?
There was a problem hiding this comment.
no, it is the variable that assigned to $cacheName, so without ".php", previously, we double call str_replace to $view to remove ".php".
$view with ".php" still used in next flow on append to viewPath.
samsonasik
force-pushed
the
reduce-str-replace-parser
branch
from
bed26b2 to
b1c5aea
Compare
|
@lonnieezell I've updated the code to not introduce new variable, so, it uses existing $view variable without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.