Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1135 : Toolbar oldest file delete and show maximum in the list as App::toolbarMaxHistory #1155

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Fixes #1135 : Toolbar oldest file delete and show maximum in the list as App::toolbarMaxHistory #1155

merged 1 commit into from
Aug 10, 2018

Conversation

samsonasik
Copy link
Member

Fixes #1135

@samsonasik
Copy link
Member Author

Before:

before

After:

after

  • oldest files deleted first when $i+1 > App::toolbarMaxHistory, which is 20, so, when on the 21th hit, the oldest file will be deleted.
  • show list history files maximum as App::toolbarMaxHistory property, which is 20, previously, it shown as 21.

@samsonasik samsonasik changed the title Fixes #1135 Fixes #1135 : Toolbar oldest file delete and show maximum in the list as App::toolbarMaxHistory Aug 10, 2018
@samsonasik samsonasik mentioned this pull request Aug 10, 2018
Closed
@lonnieezell lonnieezell merged commit 303aaab into codeigniter4:develop Aug 10, 2018
@samsonasik samsonasik deleted the fix-1135 branch August 10, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @lonnieezell