Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements session->push() #1151

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions system/Session/Session.php
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,24 @@ public function has(string $key)
return isset($_SESSION[$key]);
}

//--------------------------------------------------------------------

/**
* Push new value onto session value that is array.
*
* @param string $key Identifier of the session property we are interested in.
* @param array $data value to be pushed to existing session key.
*
* @return void
*/
public function push(string $key, array $data)
{
if ($this->has($key) && is_array($value = $this->get($key)))
{
$this->set($key, array_merge($value, $data));
}
}

//--------------------------------------------------------------------

/**
Expand Down
17 changes: 17 additions & 0 deletions tests/system/Session/SessionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,23 @@ public function testHasReturnsFalseOnNotFound()
$this->assertFalse($session->has('bar'));
}

public function testPushNewValueIntoArraySessionValue()
{
$session = $this->getInstance();
$session->start();

$session->set('hobbies', ['cooking' => 'baking']);
$session->push('hobbies', ['sport'=>'tennis']);

$this->assertEquals(
[
'cooking' => 'baking',
'sport' => 'tennis',
],
$session->get('hobbies')
);
}

public function testRemoveActuallyRemoves()
{
$session = $this->getInstance();
Expand Down