Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

See method in controller testing does not recognize accents #3319

Closed
luispastendev opened this issue Jul 15, 2020 · 2 comments · Fixed by #3324
Closed

See method in controller testing does not recognize accents #3319

luispastendev opened this issue Jul 15, 2020 · 2 comments · Fixed by #3324

Comments

@luispastendev
Copy link

it seems that there is a bug in the functions that read the dom, since when looking for letters with accents the tests fail.

$result->see('Recuperación de contraseña')

Regards!
samsonasik added a commit to samsonasik/CodeIgniter4 that referenced this issue Jul 15, 2020
@samsonasik
Fixes codeigniter4#3319 add multibyte support on Domparser::see()
e93e164
@samsonasik samsonasik mentioned this issue Jul 15, 2020
Merged
2 tasks
@samsonasik
Copy link
Member

Please check if #3324 fix it.

@luispastendev
Copy link
Author

Thank you very much @samsonasik your PR solved the support for strings with accents

Regards :)!

lonnieezell added a commit that referenced this issue Jul 16, 2020
@lonnieezell
Merge pull request #3324 from samsonasik/support-multibyte-search-on-…
1ebffe7 
…domparser-see

Fixes #3319 add multibyte support on DOMParser::see()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3319 add multibyte support on DOMParser::see() samsonasik/CodeIgniter4
2 participants
@samsonasik @luispastendev