Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisHandler, Session regenerate id problem #318

Closed
byazrail opened this issue Nov 30, 2016 · 6 comments
Closed

RedisHandler, Session regenerate id problem #318

byazrail opened this issue Nov 30, 2016 · 6 comments

Comments

@byazrail
Copy link
Contributor

byazrail commented Nov 30, 2016

Hi all,

session_regenerate_id(): Failed to create(read) session ID: user (path: /var/lib/php/session)
on redis driver.


Handler;
If you need it, see : Handler
Fix;
If you need it, see : byazrail@f21a857

@byazrail
Copy link
Contributor Author

Hi all,

Handler;
If you need it, see : Handler
Fix;
If you need it, see : byazrail@f21a857

@byazrail byazrail changed the title Session regenerate id problem RedisHandler, Session regenerate id problem Nov 30, 2016
@lonnieezell
Copy link
Member

Thanks for digging into this! Really appreciate it. In the future, a pull request would be simpler to handle here, though, if you can. Will try to get this incorporated tonight.

@byazrail
Copy link
Contributor Author

You are very welcome. I'm working on it. Let's see.

@byazrail
Copy link
Contributor Author

byazrail commented Nov 30, 2016

I'm working on the Oci8 Database Connection Driver.
As soon as possible i'll check test then i will return test results.
Dev see - byazrail@ded36bb
screen shot 2016-12-01 at 00 34 26
screen shot 2016-12-01 at 00 34 58

lonnieezell added a commit that referenced this issue Dec 1, 2016
@lonnieezell
Copy link
Member

Great news about Oracle driver! Looking forward to it, though not looking forward to getting Travis setup to test it properly. :)

I believe the last commit should fix up the session drivers. Unfortunately, that was a sloppy port from CI3 and doesn't have any tests written for it, but I should have that issue, and a few others I found, fixed now. Let me know if it's still broke.

@byazrail
Copy link
Contributor Author

byazrail commented Dec 1, 2016

Hello,
Last commit great, but problem continue.

redishandler;
lockSession function;
if (isset($this->lockKey))
{
return $this->redis->setTimeout($this->lockKey, 300);
}
find replace;
if ($this->lockKey === $this->keyPrefix.$session_id.':lock')
{
return $this->redis->setTimeout($this->lockKey, 300);
}

have a nice day...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants