Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line 374 in system/Entity.php json_encode add JSON_UNESCAPED_UNICODE #3059

Closed
leo-at-itartpro opened this issue Jun 2, 2020 · 1 comment
Closed

Comments

@leo-at-itartpro
Copy link

Describe the bug
When saving stuff to database, using $entity->property, with property being cast as json-array it does a poor job of saving for russian, and I suspect other languages. Is it possible to set line 374 in system/Entity.php to this: json_encode($value, JSON_UNESCAPED_UNICODE);

Add JSON_UNESCAPED_UNICODE to handle different languages? Otherwise it takes a lot of space in database when each letter is represented as \u043d (for example)

CodeIgniter 4 version
4.0.3

Affected module(s)
CodeIgniter\Entity

@lonnieezell
Copy link
Member

I think this makes sense. Will do.

MGatner added a commit that referenced this issue Jun 13, 2020
Don't escape unicode characters when saving JSON from Entities. Fixes #3059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants