Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mess Detector rules #184

Closed
jim-parry opened this issue Jul 20, 2016 · 3 comments
Closed

Mess Detector rules #184

jim-parry opened this issue Jul 20, 2016 · 3 comments
Labels
help wanted More help is needed for the proper resolution of an issue or pull request

Comments

@jim-parry
Copy link
Contributor

Looking for someone familiar with Mess Detector to create a ruleset matching our style guide, or the common deviations from it or other bad smells.
This is initially intended for use inside an IDE, and ultimately perhaps as part of our travis-ci build.

@jim-parry jim-parry added the help wanted More help is needed for the proper resolution of an issue or pull request label Jul 20, 2016
@jim-parry
Copy link
Contributor Author

That is a possibility. I am trying to cover all the bases, and hope that we get one that works.

The three suggested are the ones supported by my IDE, apparently for different purposes.

If a single tool would do the trick - detecing, reporting and fixing, both inside an IDE and as part of travis-ci, that would be good.


From: cryode [email protected]
Sent: Wednesday, July 20, 2016 3:15 PM
To: bcit-ci/CodeIgniter4
Cc: James Parry; Author
Subject: Re: [bcit-ci/CodeIgniter4] Mess Detector rules (#184)

Suggest possibly using PHP CS Fixerhttps://github.com/FriendsOfPHP/PHP-CS-Fixer to help with formatting code automatically, on top of or in lieu of mess detector.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/184#issuecomment-234100714, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADDjb-A44N3OmxBQcrEVRJUEJYOi0_MTks5qXp4TgaJpZM4JQ8fK.

@mwhitneysdsu
Copy link
Contributor

Out of curiosity, I installed Mess Detector and ran it on selected classes in my CI3 codebase. The information it provides is very different from PHP-CS. I think there's a remote possibility that you could write rules for PHP-CS to do the same thing, but it would seem like an odd thing to spend your time on, given that MD works, and you would probably take a less automated approach to dealing with MD results.

@jim-parry
Copy link
Contributor Author

It looks like the traction is with the code sniffer and not the mess detector.
Putting this one to sleep :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted More help is needed for the proper resolution of an issue or pull request
Projects
None yet
Development

No branches or pull requests

2 participants