Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Configuration file #1309

Closed
smartnathan opened this issue Oct 11, 2018 · 9 comments
Closed

Environment Configuration file #1309

smartnathan opened this issue Oct 11, 2018 · 9 comments
Labels
waiting for info Issues or pull requests that need further clarification from the author

Comments

@smartnathan
Copy link

Environment Configuration file does not work even after uncommenting adding the value.

@jim-parry
Copy link
Contributor

A few more details? This doesn't give enough to work with.

@smartnathan
Copy link
Author

smartnathan commented Oct 11, 2018 via email

@jim-parry jim-parry added the waiting for info Issues or pull requests that need further clarification from the author label Oct 19, 2018
@Xcreen
Copy link

Xcreen commented Oct 19, 2018

I have the same problem. (or understanding the .env-configuration wrong)

For example i uncommenting app.baseURL in the .env-file(in root folder) and added the value there.
And leaving application/Config/App.php as default ($baseURL = '';).
The value will not be changed, so page throws error (empty or invalid base URL).
(I can access $_ENV['app.baseURL'] is Controller, but not in the Config)

I guess that is something the issue-creator have also done.

@smartnathan
Copy link
Author

smartnathan commented Oct 19, 2018 via email

@lonnieezell
Copy link
Member

What is your OS and other details @Xcreen?

I'm on a Mac using the following line in .env and it works just fine:

app.baseURL=http://localhost:8080

@Xcreen
Copy link

Xcreen commented Oct 24, 2018

OS: Windows 10 (1803)
Xampp with: Apache/2.4.34 (Win32) OpenSSL/1.0.2o PHP/7.1.22

I tested again and cant reproduce... not sure why its working now and not before...

@lonnieezell
Copy link
Member

@Xcreen Any chance you could try to debug that? I don't have a Windows/Xampp machine around to test it on.

or if you and @smartnathan cannot reproduce anymore we can just close it.

@Xcreen
Copy link

Xcreen commented Nov 2, 2018

I tried to reproduce with alpha-2, but it was working as expected.
If rename the env-file in .env and set app.baseurl is working.

But im not sure why we have a .env file in the application-folder?
Because that .env is not working there. Maybe that was the issue, that i tried to add it in that file.

@jim-parry
Copy link
Contributor

The .env in the application folder was wrong, and has been removed.
Good that this is working as expected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for info Issues or pull requests that need further clarification from the author
Projects
None yet
Development

No branches or pull requests

4 participants