System/Database/Database.php::loadForge returns Connection when using custom DBDriver

[Martin-4Spaces]

I'm extending the DBDrivers and therefore specifying my own namespace in database config. But.. Then this line will return a Connection class. I guess it should always return the Forge? :-)

[jim-parry]

Reading that source line, loadForge(...) should return a Forge object if the $db connection driver name doesn't contain a backslash, and a Connection object if it does.
So, no, it would not always return a Forge (generally).
If your DBDriver name always includes a namespace, then I would think that it would return a Forge.

If loadForge(...) isn't behaving as expected, can you provide some sample code? Thanks.

[Martin-4Spaces]

The purpose of loadForge is "Create a new Forge instance for the current database type".
The default DBDriver name (mysql/mysqli/..) does not include namespace (no \) and therefore it will return a Forge object with \CodeIgniter\Database\ as namespace.
To use my own DBDriver I will have to specify the namespace in DBDriver name. Ex. \MyDatabaseDriver\Mysqli. Becasuse of the \ this line will return an instance of \MyDatabaseDriver\Mysqli\Connection.
The frameworks does not expect to get a Connection-object when calling loadForge and stuff starts to break down cause of that :D

I hope this explains the issue.
The solution is to replace '\Connection' with '\Forge'.

[lonnieezell]

I believe that should return a Forge instance always. It looks like a flub from when I ported from CI3. Will fix.