Merge pull request #2883 from jreklund/url_title

Build Your First Application used url_title incorrectly
codeigniter4 · Apr 27, 2020 · f6286ac · f6286ac
2 parents f310c91 + 07c9d3c
commit f6286ac
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/system/Helpers/url_helper.php b/system/Helpers/url_helper.php
@@ -601,7 +601,6 @@ function url_title(string $str, string $separator = '-', bool $lowercase = false
 		$str = strip_tags($str);
 		foreach ($trans as $key => $val)
 		{
-			//			$str = preg_replace('#'.$key.'#i'.( UTF8_ENABLED ? 'u' : ''), $val, $str);
 			$str = preg_replace('#' . $key . '#iu', $val, $str);
 		}
 

diff --git a/user_guide_src/source/tutorial/create_news_items.rst b/user_guide_src/source/tutorial/create_news_items.rst
@@ -61,7 +61,7 @@ validation <../libraries/validation>` library to do this.
         {
             $model->save([
                 'title' => $this->request->getVar('title'),
-                'slug'  => url_title($this->request->getVar('title')),
+                'slug'  => url_title($this->request->getVar('title'), '-', TRUE),
                 'body'  => $this->request->getVar('body'),
             ]);